Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

getUserMedia works wrong #68

Closed
jauhenk opened this issue Apr 28, 2015 · 9 comments
Closed

getUserMedia works wrong #68

jauhenk opened this issue Apr 28, 2015 · 9 comments

Comments

@jauhenk
Copy link

jauhenk commented Apr 28, 2015

Hey guys,
When I path to the getUserMedia { audio: true, video: false } I still can select video in the popup window. After it I'll be able to get video stream from the stream object in the getUserMedia success callback.
Thanks!

@johache
Copy link
Contributor

johache commented Apr 30, 2015

It was a design choice to let the user override the request made by the website.
Re-reading the specs, I do understand that if the request says no video, the stream MUST not contain a video track.
http://www.w3.org/TR/2015/WD-mediacapture-streams-20150414/#idl-def-MediaStreamConstraints

@agouaillard : what do you think?

@agouaillard
Copy link

I think the spec is clear.
if the constraint is videoL false, the resulting media stream MUST not have
a video track.
In such case it makes no sense to have a prompt for video at all (you take
the risk to start a video capturer for nothing).

On Thu, Apr 30, 2015 at 10:07 AM, Jacques-Olivier Haché <
notifications@github.com> wrote:

It was a design choice to let the user override the request made by the
website.
Re-reading the specs, I do understand that if the request says no video,
the stream MUST not contain a video track.

http://www.w3.org/TR/2015/WD-mediacapture-streams-20150414/#idl-def-MediaStreamConstraints

@agouaillard https://github.com/agouaillard : what do you think?


Reply to this email directly or view it on GitHub
#68 (comment).

Alex. Gouaillard, PhD, PhD, MBA

CTO - Temasys Communications, S'pore / Mountain View

President - CoSMo Software, Cambridge, MA

sg.linkedin.com/agouaillard

@rpastro
Copy link

rpastro commented May 7, 2015

I agree with @agouaillard. We should not allow the user to overwrite what is being requested by the JS app.

Please note that this should also be applicable for the case where the constraint has audio: false. In this case the user should not be allowed to select a recording device.

@johache
Copy link
Contributor

johache commented May 20, 2015

Alright, ticket open in JIRA.

@jauhenk
Copy link
Author

jauhenk commented Jul 23, 2015

Hey,
Is it possible to remove video stream manually somehow? When I disable video track sound become disabled also.

@johache
Copy link
Contributor

johache commented Jul 23, 2015

1 - FYI, I implemented the forced respect of the constraints last week. it will be a part of the next release.
2 - Do you mean removing the video track from the stream while keeping the audio track ? MediaStream.removeTrack will also be in the next release.
Did you try getting the video track and setting it to enabled = false ?

@jauhenk
Copy link
Author

jauhenk commented Jul 23, 2015

Sounds good!
2 - Yes, but when we will have correct getUserMedia flow - all will be fine

  • Did you try getting the video track and setting it to enabled = false ?
  • Yes, and sound also became disabled after it.

@jauhenk
Copy link
Author

jauhenk commented Jul 23, 2015

Also could you please let me know when next release will be?

@johache
Copy link
Contributor

johache commented Oct 5, 2015

A release including those fixes was done on Aug 13, closing this issue.
https://temasys.atlassian.net/wiki/display/TWPP/WebRTC+Plugins

@johache johache closed this as completed Oct 5, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants