Nopage #8
Merged
Nopage #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Add single-value, delete-data-points |
| // tags.add("delete"); | ||
| // Sensor sensor = new Sensor("delete-sensor", "name", tags, new HashMap<String, String>()); | ||
| // tags.add("deleteDataPoints"); | ||
| // Sensor sensor = new Sensor("deleteDataPoints-sensor", "name", tags, new HashMap<String, String>()); | ||
| // Result<Sensor> result1 = client.createSensor(sensor); |
| @@ -419,6 +419,61 @@ public DataPointRowCursor read(Selection selection, DateTime start, DateTime sto | |||
| return read(selection, new Pipeline(), start, stop); | |||
| } | |||
|
|
|||
| public DataPointRowCursor latest(Selection selection, Pipeline pipeline) { | |||
| checkNotNull(selection); | |||
There was a problem hiding this comment.
Does pipeline need a NULL check as well, or is it ok to pass a null pipeline into a Query?
There was a problem hiding this comment.
We have null-checking code specifically for a null pipeline elsewhere, but I think we should just accept a default parameter instead of a null pipeline; i'll make the change
| @@ -11,6 +11,10 @@ | |||
|
|
|||
| public DataPointIterator(DataPointRowCursor rowCursor, String deviceKey, String sensorKey) { | |||
| this.rowIterator = rowCursor.iterator(); | |||
| System.out.println("ROW ITERATOR: "); | |||
There was a problem hiding this comment.
Should we remove these print statements?
There was a problem hiding this comment.
yes we should. will do now
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.