Improve seek method with 'canplay' event handling in VideoReader #2003
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhalice2011
requested review from
domchen,
lvpengwei and
luckyzhliu
as code owners
Improve seek method with 'canplay' event handling in VideoReader
zhalice2011
force-pushed
the
bugfix/dalyzhou_seek_not_work
branch
from
494bcab
to
994926a
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2003 +/- ##
==========================================
- Coverage 60.73% 60.72% -0.02%
==========================================
Files 383 383
Lines 22017 22017
Branches 6375 6375
==========================================
- Hits 13372 13369 -3
- Misses 4664 4670 +6
+ Partials 3981 3978 -3 ☔ View full report in Codecov by Sentry. |
domchen
approved these changes
Dec 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.