Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the NPR issue when Font.getTypeface() returns nullptr. #2266

Merged
merged 1 commit into from
Apr 23, 2024

Conversation

domchen
Copy link
Collaborator

@domchen domchen commented Apr 23, 2024

No description provided.

@domchen domchen merged commit 251d408 into main Apr 23, 2024
7 checks passed
@domchen domchen deleted the bugfix/domchen_typeface branch April 23, 2024 04:54
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 13.33333% with 13 lines in your changes missing coverage. Please review.

Project coverage is 61.62%. Comparing base (b6ce2a5) to head (5ddce8c).
Report is 19 commits behind head on main.

Files with missing lines Patch % Lines
src/rendering/utils/shaper/TextShaperHarfbuzz.cpp 33.33% 2 Missing and 2 partials ⚠️
src/rendering/graphics/Glyph.cpp 0.00% 0 Missing and 3 partials ⚠️
src/rendering/caches/TextAtlas.cpp 0.00% 0 Missing and 2 partials ⚠️
src/rendering/caches/TextBlock.cpp 0.00% 0 Missing and 1 partial ⚠️
src/rendering/caches/TextContentCache.cpp 0.00% 0 Missing and 1 partial ⚠️
src/rendering/graphics/Text.cpp 0.00% 0 Missing and 1 partial ⚠️
src/rendering/utils/shaper/TextShaperPrimitive.cpp 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2266      +/-   ##
==========================================
+ Coverage   61.53%   61.62%   +0.09%     
==========================================
  Files         385      385              
  Lines       22064    22063       -1     
  Branches     6420     6422       +2     
==========================================
+ Hits        13577    13597      +20     
+ Misses       4445     4442       -3     
+ Partials     4042     4024      -18     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants