Fix destroy_gpu_instance crash
#5353
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nihui
reviewed
Mar 1, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5353 +/- ##
=======================================
Coverage 94.48% 94.48%
=======================================
Files 778 778
Lines 243352 243355 +3
=======================================
+ Hits 229921 229924 +3
Misses 13431 13431 ☔ View full report in Codecov by Sentry. |
nihui
approved these changes
Mar 4, 2024
|
Thanks for your contribution ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
destroy_gpu_instancecrashes whencreate_gpu_instanceexecution fails.for example it will crash in the
__ncnn_vulkan_instance_holderdestructor on program exit if there is no vulkan driver found.