Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tabs): fix double trigger onchange #254

Merged
merged 5 commits into from
Jul 29, 2022
Merged

Conversation

TingShine
Copy link
Contributor

@TingShine TingShine commented Jul 27, 2022

fix #253

🤔 这个 PR 的性质是?

  • 日常 bug 修复
  • 新特性提交
  • 文档改进
  • 演示代码改进
  • 组件样式/交互改进
  • CI/CD 改进
  • 重构
  • 代码风格优化
  • 测试用例
  • 分支合并
  • 其他

🔗 相关 Issue

Tabs两次触发onChange

💡 需求背景和解决方案

手动切换tab时如果改变了传入的value值(与切换的tab值一致),会触发第二次onChange

📝 更新日志

  • fix(Tabs): 修复传入相同的值时仍触发 onChange 的问题

@github-actions
Copy link
Contributor

github-actions bot commented Jul 27, 2022

完成

src/tabs/tabs.vue Outdated Show resolved Hide resolved
Copy link
Collaborator

@josonyang josonyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

src/tabs/tabs.vue Outdated Show resolved Hide resolved
Copy link
Collaborator

@LeeJim LeeJim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@LeeJim LeeJim merged commit 6b40df4 into Tencent:develop Jul 29, 2022
@github-actions github-actions bot mentioned this pull request Aug 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Tabs] 切换tab时会触发两次onChange
3 participants