Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(DropdownMenu): support keys #769

Merged
merged 2 commits into from
Jun 1, 2023
Merged

fix(DropdownMenu): support keys #769

merged 2 commits into from
Jun 1, 2023

Conversation

ccccpj
Copy link
Collaborator

@ccccpj ccccpj commented May 31, 2023 •
edited by anlyyao
Loading

🤔 这个 PR 的性质是？

  • 日常 bug 修复
  • 新特性提交
  • 文档改进
  • 演示代码改进
  • 组件样式/交互改进
  • CI/CD 改进
  • 重构
  • 代码风格优化
  • 测试用例
  • 分支合并
  • 其他

🔗 相关 Issue

fix #755

💡 需求背景和解决方案

📝 更新日志

  • fix(DropdownMenu): 修复 keys 属性无效的问题

  • 本条 PR 不需要纳入 Changelog

☑️ 请求合并前的自查清单

⚠️ 请自检并全部勾选全部选项。⚠️

  • 文档已补充或无须补充
  • 代码演示已提供或无须提供
  • TypeScript 定义已补充或无须补充
  • Changelog 已提供或无须提供

@ccccpj ccccpj requested a review from anlyyao May 31, 2023 16:25
@github-actions
Copy link
Contributor

Size Change: +331 B (0%)

Total Size: 469 kB

Filename Size Change
./dist/tdesign.js 276 kB +206 B (0%)
./dist/tdesign.min.js 133 kB +125 B (0%)
ℹ️ View Unchanged
Filename Size
./dist/tdesign.css 35.1 kB
./dist/tdesign.min.css 25.5 kB

@github-actions
Copy link
Contributor

github-actions bot commented May 31, 2023 •
edited
Loading

完成

@github-actions
Copy link
Contributor

Size Change: +331 B (0%)

Total Size: 469 kB

Filename Size Change
./dist/tdesign.js 276 kB +206 B (0%)
./dist/tdesign.min.js 133 kB +125 B (0%)
ℹ️ View Unchanged
Filename Size
./dist/tdesign.css 35.1 kB
./dist/tdesign.min.css 25.5 kB

LeeJim
LeeJim requested changes Jun 1, 2023
View reviewed changes
src/dropdown-menu/dropdown-item.vue Outdated Show resolved Hide resolved
src/dropdown-menu/dropdown-item.vue Outdated Show resolved Hide resolved
src/dropdown-menu/dropdown-item.vue Outdated Show resolved Hide resolved
@anlyyao anlyyao requested review from LeeJim and removed request for anlyyao June 1, 2023 08:09
@github-actions
Copy link
Contributor

github-actions bot commented Jun 1, 2023

Size Change: +368 B (0%)

Total Size: 469 kB

Filename Size Change
./dist/tdesign.js 276 kB +244 B (0%)
./dist/tdesign.min.js 133 kB +124 B (0%)
ℹ️ View Unchanged
Filename Size
./dist/tdesign.css 35.1 kB
./dist/tdesign.min.css 25.5 kB

@LeeJim LeeJim merged commit 5b66f72 into develop Jun 1, 2023
@LeeJim LeeJim deleted the fix/dropdown-menu-keys branch June 1, 2023 08:26
@github-actions github-actions bot mentioned this pull request Jun 6, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LeeJim LeeJim Awaiting requested review from LeeJim

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[DropdownMenu] keys属性没有用
2 participants
@ccccpj @LeeJim