Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: col 组件支持跨层级响应 gutter 配置 #1167

Closed
wants to merge 2 commits into from

Conversation

honkinglin
Copy link
Collaborator

@honkinglin honkinglin commented Jul 25, 2022

🤔 这个 PR 的性质是?

  • 日常 bug 修复
  • 新特性提交
  • 文档改进
  • 演示代码改进
  • 组件样式/交互改进
  • CI/CD 改进
  • 重构
  • 代码风格优化
  • 测试用例
  • 分支合并
  • 其他

🔗 相关 Issue

💡 需求背景和解决方案

📝 更新日志

  • feat(Grid): col 组件支持跨层级响应 gutter 配置

  • 本条 PR 不需要纳入 Changelog

☑️ 请求合并前的自查清单

⚠️ 请自检并全部勾选全部选项⚠️

  • 文档已补充或无须补充
  • 代码演示已提供或无须提供
  • TypeScript 定义已补充或无须补充
  • Changelog 已提供或无须提供

@honkinglin
Copy link
Collaborator Author

re #1163

@codecov-commenter
Copy link

codecov-commenter commented Jul 25, 2022

Codecov Report

Merging #1167 (97033a0) into develop (c4c5d1d) will decrease coverage by 0.02%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           develop    #1167      +/-   ##
===========================================
- Coverage    60.18%   60.15%   -0.03%     
===========================================
  Files          959      959              
  Lines        16979    16988       +9     
  Branches      3906     3906              
===========================================
+ Hits         10218    10219       +1     
- Misses        6761     6769       +8     
Impacted Files Coverage Δ
src/grid/Col.tsx 97.29% <100.00%> (ø)
src/grid/Row.tsx 75.86% <100.00%> (-1.19%) ⬇️
src/tree/useStore.ts 57.14% <0.00%> (-4.93%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 51055e5...97033a0. Read the comment docs.

@honkinglin honkinglin closed this Jul 26, 2022
@honkinglin honkinglin reopened this Jul 26, 2022
@Tencent Tencent deleted a comment from github-actions bot Jul 26, 2022
@honkinglin honkinglin closed this Jul 26, 2022
@uyarn uyarn deleted the feat/grid/gutter branch July 26, 2022 07:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants