Fix watermark loading status #2094
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
duanbaosheng
requested review from
honkinglin,
uyarn and
carolin913
as code owners
|
|
carolin913
approved these changes
Mar 28, 2023
This was referenced Mar 30, 2023
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤔 这个 PR 的性质是？
🔗 相关 Issue
https://codesandbox.io/s/tdesign-react-demo-forked-ul7632?file=/src/demo.jsx
waterMark 包裹loading组件，loading组件无法该变状态。
💡 需求背景和解决方案
watermark组件中，监控 watermark 组件内部包裹的元素的删除事件，如果子元素被删除后，则会重新将被删除的元素添加回去，这就导致loading组件只能被加到dom中，在改变状态的时候，无法移除loading组件。
修改这个逻辑，只对对watermark包裹的 水印子元素做监控，水印子元素被删除，重新添加
📝 更新日志
fix(组件名称): 处理问题或特性描述 ...
本条 PR 不需要纳入 Changelog
☑️ 请求合并前的自查清单