Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: support ref props & remove backTopDefaultProps #2202

Merged
merged 2 commits into from
May 10, 2023

Conversation

li-jia-nan
Copy link
Contributor

remove backTopDefaultProps

BREAKING CHANGE: 🧨 none

✅ Closes: none

🤔 这个 PR 的性质是?

  • 日常 bug 修复
  • 新特性提交
  • 文档改进
  • 演示代码改进
  • 组件样式/交互改进
  • CI/CD 改进
  • 重构
  • 代码风格优化
  • 测试用例
  • 分支合并
  • 其他

🔗 相关 Issue

💡 需求背景和解决方案

📝 更新日志

  • fix(组件名称): 处理问题或特性描述 ...

  • 本条 PR 不需要纳入 Changelog

☑️ 请求合并前的自查清单

⚠️ 请自检并全部勾选全部选项⚠️

  • 文档已补充或无须补充
  • 代码演示已提供或无须提供
  • TypeScript 定义已补充或无须补充
  • Changelog 已提供或无须提供

remove backTopDefaultProps

BREAKING CHANGE: 🧨 none

✅ Closes: none
@github-actions
Copy link
Contributor

github-actions bot commented May 9, 2023

失败

@li-jia-nan
Copy link
Contributor Author

顺便问一下,迁移 defaultProps 的话,每个组件要单独提 PR ?还是可以混在一起呀?(虽然混在一起不太合乎流程)

@honkinglin
Copy link
Collaborator

honkinglin commented May 9, 2023

顺便问一下,迁移 defaultProps 的话,每个组件要单独提 PR ?还是可以混在一起呀?(虽然混在一起不太合乎流程)

方便的话还是一个一个来吧。一起提的话代码多了review也有点麻烦

@li-jia-nan
Copy link
Contributor Author

顺便问一下,迁移 defaultProps 的话,每个组件要单独提 PR ?还是可以混在一起呀?(虽然混在一起不太合乎流程)

方便的话还是一个一个来吧。一起提的话代码多了review也有点麻烦

OK

src/back-top/BackTop.tsx Outdated Show resolved Hide resolved
support ref props

BREAKING CHANGE: 🧨 none

✅ Closes: none
@li-jia-nan li-jia-nan changed the title refactor: 💡 remove backTopDefaultProps refactor: support ref props & remove backTopDefaultProps May 9, 2023
@honkinglin honkinglin merged commit 20df05a into Tencent:develop May 10, 2023
@github-actions github-actions bot mentioned this pull request May 10, 2023
16 tasks
@li-jia-nan li-jia-nan deleted the backtop branch May 10, 2023 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants