feat(select): support delete tag by keyboard backspace #241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhangbocodes
requested review from
carolin913,
honkinglin and
uyarn
as code owners
|
更新了单测，需npm run test:update更新下snapshot |
uyarn
reviewed
Jan 17, 2022
|
看起来好像snapshot还是没更新？ |
uyarn
approved these changes
Jan 19, 2022
uyarn
pushed a commit
that referenced
this pull request
Apr 18, 2022
* feat(select): support delete tag by keyboard backspace #206 * test: update test snapshot * test: update ssr test snapshot Co-authored-by: zhangbo35 <zhangbo35@baidu.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
issue #206
新增一个feat，在multiple+filterable的情况下支持通过backspace删除tag
另外multiple+filterable的时候，初始化会显示searchValue为第一个tag的value，这个是by design么？感觉应该和placeholder逻辑一样，当multiple的时候就不默认带入searchValue了