Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/tiennecheng watermark markchange #2459

Conversation

tingtingcheng6
Copy link
Contributor

@tingtingcheng6 tingtingcheng6 commented Aug 23, 2023

🤔 这个 PR 的性质是?

  • 日常 bug 修复
  • 新特性提交
  • 文档改进
  • 演示代码改进
  • 组件样式/交互改进
  • CI/CD 改进
  • 重构
  • 代码风格优化
  • 测试用例
  • 分支合并
  • 其他

🔗 相关 Issue

💡 需求背景和解决方案

  1. 解决的具体问题:watermark组件中操作水印节点都不影响水印展示
  2. 最终的 API 实现和用法:mutationobserver监听岛水印节点变化,先remover再重新append

📝 更新日志

  • fix(watermark): watermark组件,修改水印节点,都不影响水印展示

  • 本条 PR 不需要纳入 Changelog

☑️ 请求合并前的自查清单

⚠️ 请自检并全部勾选全部选项⚠️

  • 文档已补充或无须补充
  • 代码演示已提供或无须提供
  • TypeScript 定义已补充或无须补充
  • Changelog 已提供或无须提供

@github-actions
Copy link
Contributor

github-actions bot commented Aug 23, 2023

完成

Copy link
Collaborator

@carolin913 carolin913 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

删除节点恢复功能有问题,再看下

水印数据渲染问题优化
@carolin913 carolin913 merged commit 5a5466b into Tencent:develop Aug 24, 2023
4 checks passed
@github-actions github-actions bot mentioned this pull request Aug 31, 2023
16 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants