Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(image-viewer): feat add defaultScale and closeOnEscKeydown #2652

Merged
merged 1 commit into from
Dec 13, 2023

Conversation

HaixingOoO
Copy link
Collaborator

🤔 这个 PR 的性质是?

  • 日常 bug 修复
  • 新特性提交
  • 文档改进
  • 演示代码改进
  • 组件样式/交互改进
  • CI/CD 改进
  • 重构
  • 代码风格优化
  • 测试用例
  • 分支合并
  • 其他

🔗 相关 Issue

💡 需求背景和解决方案

图片预览添加默认的缩放比例和按下 ESC 时是否触发图片预览器关闭事件

📝 更新日志

  • fix(ImageViewer): 图片预览添加默认的缩放比例和按下 ESC 时是否触发图片预览器关闭事件

  • 本条 PR 不需要纳入 Changelog

☑️ 请求合并前的自查清单

⚠️ 请自检并全部勾选全部选项⚠️

  • 文档已补充或无须补充
  • 代码演示已提供或无须提供
  • TypeScript 定义已补充或无须补充
  • Changelog 已提供或无须提供

Copy link
Contributor

完成

Copy link
Collaborator

@uyarn uyarn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@uyarn uyarn merged commit d5b3cc7 into Tencent:develop Dec 13, 2023
5 checks passed
@HaixingOoO HaixingOoO deleted the feat/image-viewer branch December 13, 2023 11:29
@github-actions github-actions bot mentioned this pull request Dec 14, 2023
16 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants