feat: 多标签Tab页支持拖拽排序 #426
Merged
feat: 多标签Tab页支持拖拽排序 #426
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
没有其他问题 但是建议增加下对HomePage的判断 如果和HomePage换序( index 0 )就return不用执行了 不然一些关闭左右的逻辑涉及HomePage的就也要跟着改动了 |
已调整，如果组件库tabs拖拽支持配置选项卡禁止拖拽更好 |
|
不对 .. 这个drag其实不是受控的 跟在dragend的回调里没有关系 .. drag-sort 开启 组件内自己做顺序的控制 其实没有暴露API来做受控 |
timi137137
requested changes
Feb 20, 2023
|
@uyarn 重新调整了右键关闭的逻辑，看看有没有问题 |
uyarn
approved these changes
Feb 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤔 这个 PR 的性质是？
🔗 相关 Issue
💡 需求背景和解决方案
📝 更新日志
feat: 多标签Tab页支持拖拽排序
本条 PR 不需要纳入 Changelog
☑️ 请求合并前的自查清单