Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature/suppport-global-icon #1420

Merged
merged 6 commits into from
Aug 18, 2022

Conversation

zhangpaopao0609
Copy link
Collaborator

@zhangpaopao0609 zhangpaopao0609 commented Aug 15, 2022

🤔 这个 PR 的性质是?

  • 新特性提交

🔗 相关 Issue

支持全局自定义icon:#1403

💡 需求背景和解决方案

支持自定义全局 icon

📝 更新日志

☑️ 请求合并前的自查清单

⚠️ 请自检并全部勾选全部选项⚠️

  • 文档已补充或无须补充
  • 代码演示已提供或无须提供
  • TypeScript 定义已补充或无须补充
  • Changelog 已提供或无须提供

@zhangpaopao0609
Copy link
Collaborator Author

每个修改的组件都已经自测,但因为涉及的组件众多,因此难免会由存在错该或漏改,所以还请 @PengYYYYY 帮忙做一次检查,感谢!!

@zhangpaopao0609
Copy link
Collaborator Author

在 config-provider 中增加了一个 input 密码框作为支持定义全局 icon 的demo

@github-actions
Copy link
Contributor

github-actions bot commented Aug 15, 2022

完成

@zhangpaopao0609
Copy link
Collaborator Author

zhangpaopao0609 commented Aug 15, 2022

但此 feature 个人觉得并不完整,还缺以下两点

  1. tdesign-icons-vue-next 中未导出 IconConfig,因此在代码中使用了自定义的 IconConfig,所以类型并不完整
  2. 因为 IconConfig 的缺失,所以在文档中目前也未加入相关的使用说明,因此,需要在 IconConfig 修改后添加相关的使用说明

@PengYYYYY
Copy link
Collaborator

IconConfig 我看下

@PengYYYYY PengYYYYY merged commit 4b24a41 into Tencent:develop Aug 18, 2022
@github-actions github-actions bot mentioned this pull request Aug 23, 2022
16 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants