Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Menu] menu的激活菜单项未发生变化时也会触发change #2688

Closed
vonlyinno opened this issue Aug 14, 2023 · 2 comments · Fixed by #2693
Closed

[Menu] menu的激活菜单项未发生变化时也会触发change #2688

vonlyinno opened this issue Aug 14, 2023 · 2 comments · Fixed by #2693
Assignees
@LeeJim
Labels
🐞 bug Something isn't working to be published fixed, not be published

Comments

@vonlyinno
Copy link

tdesign-vue 版本

1.5.2

重现链接

https://stackblitz.com/run?file=src%2Fdemo.vue

重现步骤

change的说明是：激活菜单项未发生变化时触发，但当前行为是点击当前高亮的菜单也会触发，约等于click

期望结果

区分change和click事件

实际结果

No response

框架版本

2.6.14

浏览器版本

No response

系统版本

No response

Node版本

No response

补充说明

No response
@github-actions
Copy link
Contributor

👋 @vonlyinno，感谢给 TDesign 提出了 issue。
请根据 issue 模版确保背景信息的完善，我们将调查并尽快回复你。

@github-actions
Copy link
Contributor

♥️ 有劳 @LeeJim @iAmber @qinmudi 尽快确认问题。
确认有效后将下一步计划和可能需要的时间回复给 @vonlyinno 。

@xiaosansiji xiaosansiji added the 🐞 bug Something isn't working label Aug 14, 2023
dexterBo added a commit to dexterBo/tdesign-vue that referenced this issue Aug 15, 2023
@dexterBo
fix(menu): menu的激活菜单项未发生变化时也会触发change
d30c695 
fix Tencent#2688
@dexterBo dexterBo mentioned this issue Aug 15, 2023
Merged
16 tasks
@xiaosansiji xiaosansiji added the to be published fixed, not be published label Aug 15, 2023
xiaosansiji pushed a commit that referenced this issue Aug 15, 2023
@dexterBo
fix(menu): menu的激活菜单项未发生变化时也会触发change (#2693)
539247e 
fix #2688
uyarn pushed a commit that referenced this issue Aug 17, 2023
@dexterBo @uyarn
fix(menu): menu的激活菜单项未发生变化时也会触发change (#2693)
4c270b4 
fix #2688
LeeJim pushed a commit that referenced this issue Aug 17, 2023
@uyarn @dexterBo
@chaishi @sinbadmaster @xiaosansiji @github-actions
feat(1.6.1): weekly sync update to naruto (#2705)
411c0d1 
* feat(menu-item): click事件参数增加value (#2689)

fix #2621

* feat: add KeyboardEvents to select; fix table some bugs (#2683)

* fix(table): virtual scroll default scroll bar height

* feat(checkbox): support Space checked

* feat(radio): support Space Keyboard to check

* fix(table): e.target.closest might not exist

* test: update snapshots

* feat(select): support keyboard selection

* feat(select): support keyboard

* feat(input): showInput with 0px width

* fix: remove unsued code

* test: update snapshots

* fix(table): drag sort invalid on lazyload

* feat: update common

* feat: update common

* fix(menu): menu的激活菜单项未发生变化时也会触发change (#2693)

fix #2688

* fix(select-input): 多选情况下按下Enter键后触发了focus事件而不是enter事件 (#2694)

fix #2525

* fix(ImageViewer): 前后浏览及关闭浏览重置图片状态 (#2685)

* fix(image-viewer): 前后浏览及关闭浏览重置图片状态

#2679

* fix(image-viewer): 清除关闭时图片状态

* Docs/affix treeselect (#2696)

* fix: affix offsetBottom/offsetTop doc

* fix: tree select keys doc

* fix(select): disable internal filter when remote search (#2699)

* chore: release/1.6.1 (#2692)

* feat: release 1.6.1

* feat: update common

* feat: update common

* feat: update common

* chore: changelog's changes

---------

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

---------

Co-authored-by: Dexter <52393227+dexterBo@users.noreply.github.com>
Co-authored-by: sheepluo <yaoyanhuoyi@qq.com>
Co-authored-by: sinbadmaster <40019023+sinbadmaster@users.noreply.github.com>
Co-authored-by: azhe <xiaosansiji@gmail.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
KMethod pushed a commit to KMethod/tdesign-vue that referenced this issue Aug 25, 2023
@dexterBo
fix(menu): menu的激活菜单项未发生变化时也会触发change (Tencent#2693)
7afde35 
fix Tencent#2688
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@LeeJim LeeJim

Labels
🐞 bug Something isn't working to be published fixed, not be published
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(menu): menu的激活菜单项未发生变化时也会触发change dexterBo/tdesign-vue
3 participants
@LeeJim @xiaosansiji @vonlyinno