fix(cascader): 修复Cascader组件label属性自定义插槽不生效 #2724
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nent was not working
|
修改了demo 需要执行 npm run test:update 修改下快照再提交上来 |
|
|
|
|
|
merge 后还是同样的问题 |
Merged
|
这个是个异步测试的问题 我触发下再跑次 |
|
@ubloglab 你应该是node 16或者更低的版本 这个测试应该得18+ 我直接更新下 |
uyarn
approved these changes
Aug 22, 2023
uyarn
added a commit
that referenced
this pull request
Aug 23, 2023
* fix(cascader): where custom slot for label property in Cascader component was not working * test(cascader): cascader tests * chore: update snapshot --------- Co-authored-by: Uyarn <uyarnchen@gmail.com>
xiaosansiji
added a commit
that referenced
this pull request
Aug 23, 2023
* fix: 控制台报错 (#2702) * feat: add cascader keys disabled (#2697) * feat: add cascader keys disabled * feat: add select keys.disabled api * feat: add transfer keys.disabled * feat: add tree keys.disabled api * feat: add tree-select keys.disabled api * fix: lint fix * test: fix select test * fix(checkbox): async options state (#2706) * fix(image): async image.src (#2709) * fix(image): async image.src * fix(image): watch immediate * chore(release): 1.6.2 (#2710) * chore(release): 1.6.2 * chore: changelog's changes --------- Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * chore: fix export type (#2711) * chore: cascader TreeKeysType export position (#2712) * feat(table): support ellipsis-content with slot (#2717) * feat(table): support defined ellipsis-content with slot * docs(table): update docs * fix(Select): improve performance when filtering options (#2722) * fix(Select): improve performance when filtering options Co-authored-by: moonye6 <464461539@qq.com> * chore: update snapshot --------- Co-authored-by: moonye6 <464461539@qq.com> * feat(Table): fix expandAll problem; support props.expandedTreeNodes control expanded nodes (#2719) * feat(table): support table expand * fix(table): expand all * docs(table): update * fix: lint error * fix(table): expandOnRowClick and selectOnRowClick conflict * feat(table): add removeChildren * fix(cascader): 修复Cascader组件label属性自定义插槽不生效 (#2724) * fix(cascader): where custom slot for label property in Cascader component was not working * test(cascader): cascader tests * chore: update snapshot --------- Co-authored-by: Uyarn <uyarnchen@gmail.com> * feat: release 1.6.3 (#2726) * feat: release 1.6.3 * feat: update common * chore: changelog's changes --------- Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * chore: import api from vue * chore: fix empty option * chore: update CHANGELOG --------- Co-authored-by: 龙风 <455947455@qq.com> Co-authored-by: PY <pengyue970715@gmail.com> Co-authored-by: sheepluo <yaoyanhuoyi@qq.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: moonye6 <464461539@qq.com> Co-authored-by: bloglab <37498563+ubloglab@users.noreply.github.com> Co-authored-by: azhe <xiaosansiji@gmail.com>
KMethod
pushed a commit
to KMethod/tdesign-vue
that referenced
this pull request
Aug 25, 2023
* fix(cascader): where custom slot for label property in Cascader component was not working * test(cascader): cascader tests * chore: update snapshot --------- Co-authored-by: Uyarn <uyarnchen@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤔 这个 PR 的性质是？
🔗 相关 Issue
[Cascader] label属性的Slot不生效 #2723
💡 需求背景和解决方案
https://codesandbox.io/s/tdesign-vue-demo-forked-c39xk3?file=/src/demo.vue
📝 更新日志
fix(cascader): 修复Cascader组件label属性自定义插槽不生效
本条 PR 不需要纳入 Changelog
☑️ 请求合并前的自查清单