Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Import cluster is failing when one or more storage nodes does not have at least one lvm #716

Merged
merged 2 commits into from
Feb 27, 2019
Merged

Import cluster is failing when one or more storage nodes does not have at least one lvm #716

merged 2 commits into from
Feb 27, 2019

Conversation

GowthamShanmugam
Copy link
Contributor

bugzilla: 1683603
tendrl-bug-id: #715

Signed-off-by: GowthamShanmugasundaram gshanmug@redhat.com

@GowthamShanmugam
Import fails when one or more storage nodes does not have any lvm par…
d77590e 
…titions on disk

bugzilla: 1683603
tendrl-bug-id: Tendrl#715

Signed-off-by: GowthamShanmugasundaram <gshanmug@redhat.com>
GowthamShanmugam
GowthamShanmugam commented Feb 27, 2019
View reviewed changes
tendrl/gluster_integration/sds_sync/brick_utilization.py
@@ -59,18 +59,30 @@ def get_lvs():
{"message": str(err)}
)
return None
out = out.split('\n')
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

out is u'' when no lvm in storage node

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So all we are doing here is checking non empty for out and adding a exception handling for parsing the out variable.
Looks good to me. Make sure this time we test all the possible scenarios.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

@GowthamShanmugam
Copy link
Contributor Author

@shtripat @nthomas-redhat @dahorak please review

nthomas-redhat
nthomas-redhat previously approved these changes Feb 27, 2019
View reviewed changes
shtripat
shtripat previously approved these changes Feb 27, 2019
View reviewed changes
Copy link
Member

@shtripat shtripat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shtripat
Copy link
Member

The pep8 issue is related to this PR or generic one?

@codecov
Copy link

codecov bot commented Feb 27, 2019 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (master@6dd8a8b). Click here to learn what that means.
The diff coverage is 0%.

Impacted file tree graph

@@           Coverage Diff            @@
##             master    #716   +/-   ##
========================================
  Coverage          ?   38.7%           
========================================
  Files             ?      42           
  Lines             ?    2108           
  Branches          ?     287           
========================================
  Hits              ?     816           
  Misses            ?    1262           
  Partials          ?      30
Impacted Files Coverage Δ
.../gluster_integration/sds_sync/brick_utilization.py 10.84% <0%> (ø)
...rl/gluster_integration/sds_sync/vol_utilization.py 8.88% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6dd8a8b...823ffa8. Read the comment docs.

@GowthamShanmugam
Copy link
Contributor Author

@shtripat I verified this fix

@GowthamShanmugam
Pep8 fix
823ffa8 
bugzilla: 1683603
tendrl-bug-id: Tendrl#715

Signed-off-by: GowthamShanmugasundaram <gshanmug@redhat.com>
@shtripat shtripat merged commit fff4e12 into Tendrl:master Feb 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shtripat shtripat shtripat left review comments

@nthomas-redhat nthomas-redhat nthomas-redhat left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@GowthamShanmugam @shtripat @nthomas-redhat