-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Invoke the integration process as service. #145
Closed
nnDarshan
wants to merge
3
commits into
Tendrl:master
from
nnDarshan:revert-133-revert-117-InvokeIntegrationAsService
Closed
Invoke the integration process as service. #145
nnDarshan
wants to merge
3
commits into
Tendrl:master
from
nnDarshan:revert-133-revert-117-InvokeIntegrationAsService
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@r0h4n @nthomas-redhat Please review |
shtripat
reviewed
Jan 17, 2017
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Correct the title of the PR. Otherwise looks fine.
nnDarshan
changed the title
Revert "Revert "Invoke the integration process as service.""
Invoke the integration process as service.
Jan 17, 2017
tendrl-bug-id: Tendrl#142 Signed-off-by: Shubhendu <shtripat@redhat.com>
tendrl-bug-id: Tendrl#116 Signed-off-by: nnDarshan <darshan.n.2024@gmail.com>
nnDarshan
force-pushed
the
revert-133-revert-117-InvokeIntegrationAsService
branch
from
January 19, 2017 09:33
ad1ca4b
to
5d6585e
Compare
Signed-off-by: nnDarshan <darshan.n.2024@gmail.com>
Some of these changes are done as part of #149. Once we merge that we can rebase this on top of that. |
Let me know if this needs to be re-opened @nnDarshan |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #133