-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
spec for import cluster #105
Conversation
Against #56 |
@brainfunked @kamleshverma1 @nthomas-redhat @anivargi @shtripat Please review it. |
Front-end related changes: | ||
|
||
* Create views for Landing page (First Time Experience), Import cluster page and page where successful message will be displayed. | ||
* Implement client side filer and sorting functionality using angular's filter and orderby components. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@julienlim What are the options for sorting and filtering on import cluster view - https://redhat.invisionapp.com/share/6T900V2ZX#/screens/198042641
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The following are the options for sort and filter for the Import Cluster view.
Filter (by): name, IP address, role (if available for Ceph)
Sort (by): name, IP address, role (if available for Ceph)
Please add usmqe/usmqe-tests#20 as reference for testing. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. One minor spelling mistake.
Front-end related changes: | ||
|
||
* Create views for Landing page (First Time Experience), Import cluster page and page where successful message will be displayed. | ||
* Implement client side filer and sorting functionality using angular's filter and orderby components. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
s/filer/filter/g
|
||
==== Tendrl API impact: | ||
|
||
Not yet decided. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@anivargi Please provide the APIs and their response which will be used in Import cluster functionality.
|
||
* "Import Cluster" can be triggered from | ||
|
||
- Landing page (First Time Experience) if no cluster is present in tendrl |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does the landing page have this option if atleast one cluster is present? I assume it lands into the dashboard in that case
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nthomas-redhat When the application gets loaded, the 1st call we make is for get cluster list call. Based on its reponse, the app decides whether it should go to landing page or cluster list view.
|
||
* User clicks on "Import Cluster". | ||
|
||
* It will take to host list page where user will select the hosts he wants to import. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
User selects a single host participating in a cluster. Upon clicking 'Next" the API gets a list of hosts participating in the cluster. I think we need to reword
* Create views for Landing page (First Time Experience), Import cluster page and page where successful message will be displayed. | ||
* Implement client side filer and sorting functionality using angular's filter and orderby components. | ||
* Send API call for host list whenevr users click "Refresh" button. | ||
* Show total count of hosts which can be imported. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What does this mean?
591c7f9
to
3e2cc08
Compare
@nthomas-redhat @brainfunked @anivargi @shtripat @kamleshverma1 I have updated the PR. Please review. |
@julienlim As we(front-end guys) have discussed with Nishanth and mrugesh, we are not going to consider bootstrap node concept while importing cluster. All clusters will be auto detected at the time of import. and in case of multiple cluster , we will have some "select drop-down" from where user can select appropriate cluster which they want to be import. or You can suggest if there is any other alternative instead of using "select drop-down" in case of multiple cluster . |
@julienlim i want some clarification on primary navigation visibility while importing cluster .
please correct me if i am wrong |
@anivargi I have gone through response format which you sent for nodelist and clusterlist . "stats":"{'alert_cnt': 10, 'storage': {'total': 42949672960, 'used': 21474836480, 'updated_at': '2016-12-19T23:12:51.278616', 'percent_used': 50}, 'cpu': {'updated_at': '2016-12-19T23:12:51.278516', 'percent_used': 4.5}, 'memory': {'total': 4294967296, 'used': 2147483648, 'updated_at': '2016-12-19T23:12:51.278593', 'percent_used': 50}}" Ideally it should be object instead of string in order to access the value of it . otherwise we need to do some extra logic unnecessary to get the value of it in UI. |
No description provided.