Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

spec for import cluster #105

Closed
wants to merge 1 commit into from
Closed

Conversation

gnehapk
Copy link
Member

@gnehapk gnehapk commented Dec 28, 2016

No description provided.

@gnehapk
Copy link
Member Author

gnehapk commented Dec 28, 2016

Against #56

@gnehapk
Copy link
Member Author

gnehapk commented Dec 28, 2016

Front-end related changes:

* Create views for Landing page (First Time Experience), Import cluster page and page where successful message will be displayed.
* Implement client side filer and sorting functionality using angular's filter and orderby components.
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@julienlim What are the options for sorting and filtering on import cluster view - https://redhat.invisionapp.com/share/6T900V2ZX#/screens/198042641

Copy link
Member

@julienlim julienlim Jan 9, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gnehapk

The following are the options for sort and filter for the Import Cluster view.

Filter (by): name, IP address, role (if available for Ceph)
Sort (by): name, IP address, role (if available for Ceph)

@mkudlej
Copy link

mkudlej commented Jan 2, 2017

Please add usmqe/usmqe-tests#20 as reference for testing.

Copy link
Contributor

@anivargi anivargi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

Copy link
Member

@shtripat shtripat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. One minor spelling mistake.

Front-end related changes:

* Create views for Landing page (First Time Experience), Import cluster page and page where successful message will be displayed.
* Implement client side filer and sorting functionality using angular's filter and orderby components.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/filer/filter/g


==== Tendrl API impact:

Not yet decided.
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@anivargi Please provide the APIs and their response which will be used in Import cluster functionality.


* "Import Cluster" can be triggered from

- Landing page (First Time Experience) if no cluster is present in tendrl
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does the landing page have this option if atleast one cluster is present? I assume it lands into the dashboard in that case

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nthomas-redhat When the application gets loaded, the 1st call we make is for get cluster list call. Based on its reponse, the app decides whether it should go to landing page or cluster list view.


* User clicks on "Import Cluster".

* It will take to host list page where user will select the hosts he wants to import.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

User selects a single host participating in a cluster. Upon clicking 'Next" the API gets a list of hosts participating in the cluster. I think we need to reword

* Create views for Landing page (First Time Experience), Import cluster page and page where successful message will be displayed.
* Implement client side filer and sorting functionality using angular's filter and orderby components.
* Send API call for host list whenevr users click "Refresh" button.
* Show total count of hosts which can be imported.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does this mean?

@gnehapk
Copy link
Member Author

gnehapk commented Jan 12, 2017

@nthomas-redhat @brainfunked @anivargi @shtripat @kamleshverma1 I have updated the PR. Please review.

@kamleshverma1
Copy link
Contributor

kamleshverma1 commented Jan 13, 2017

@julienlim As we(front-end guys) have discussed with Nishanth and mrugesh, we are not going to consider bootstrap node concept while importing cluster. All clusters will be auto detected at the time of import. and in case of multiple cluster , we will have some "select drop-down" from where user can select appropriate cluster which they want to be import. or You can suggest if there is any other alternative instead of using "select drop-down" in case of multiple cluster .

here i attached screen-shot for import cluster
screenshot from 2017-01-13 11 58 38

@kamleshverma1
Copy link
Contributor

@julienlim i want some clarification on primary navigation visibility while importing cluster .
i assumed that basically there is two case for import cluster

  1. If there is at least one cluster in Tendrl - primary navigation should be visible so that user can navigate into any other pages because we have at least one cluster in this case.

  2. If there is no any cluster in Tendrl - primary navigation should be hidden because there is no point to show navigation as we don't have anything (clusters, pools, file shares etc ) in this case.

please correct me if i am wrong

@kamleshverma1
Copy link
Contributor

@anivargi I have gone through response format which you sent for nodelist and clusterlist .
and i observed that "stats" coming as string .

"stats":"{'alert_cnt': 10, 'storage': {'total': 42949672960, 'used': 21474836480, 'updated_at': '2016-12-19T23:12:51.278616', 'percent_used': 50}, 'cpu': {'updated_at': '2016-12-19T23:12:51.278516', 'percent_used': 4.5}, 'memory': {'total': 4294967296, 'used': 2147483648, 'updated_at': '2016-12-19T23:12:51.278593', 'percent_used': 50}}"

Ideally it should be object instead of string in order to access the value of it . otherwise we need to do some extra logic unnecessary to get the value of it in UI.

@r0h4n r0h4n closed this Apr 28, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants