-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
specification for RBDs list view #108
Conversation
@gnehapk @brainfunked @anivargi @shtripat @nthomas-redhat Please review it. |
Addresses #75 . |
specs/rbd_list_view_component.adoc
Outdated
Required from API - | ||
|
||
* Response format for the API call | ||
* If "GetClusterList" contain RBDs list . than "parameter name" should be known which is holding the RBDs list. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@anivargi @shtripat @brainfunked If "GetClusterList" contain RBDs list . so Can i have "parameter name" which is holding the RBDs list ? or Is there any other APi for RBDs list ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kamleshverma1 I feel rbd listing should be a separate api like /clusters/{id}/GetRbdList. @anivargi can you confirm please?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree with @shtripat RBD list should be separated API call.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@shtripat @mkudlej Currently the API responds with all cluster related objects in 1 API call like for ex: for Ceph we have pools, but we surely have individual API calls for all storage objects like pools, RBD's in the future.
@kamleshverma1 The info will be present in the GetClusterList API call, currently I am not aware of the structure of how the details are stored in etcd and what the attributes are called, so if @shtripat or @nthomas-redhat can have a instance which has the details populated then the API will automatically respond with the desired response.
1f09244
to
a6ca497
Compare
@gnehapk @cloudbehl @anivargi @nthomas-redhat @shtripat Please review this spec . i have updated this. |
|
||
Required from API - | ||
|
||
* status |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@anivargi @nthomas-redhat @shtripat according to UX mockup (https://redhat.invisionapp.com/share/BR8JDCGSQ#/screens/198417119) , missing these fields for RBDs in given response format by anup
- status
- utilization
- alert count
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kamleshverma1 utilization
and alert count
would be done as part of monitoring I feel. I dont see a status
field as such for rbds in cli output from ceph.
specification for RBDs list view