lib embedding #219
Closed
lib embedding #219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cgrand
reviewed
Oct 23, 2023
| @@ -168,16 +169,72 @@ | |||
| (-> (Thread/currentThread) .getContextClassLoader (.getResourceAsStream "analyzer.dart") (.transferTo out)))) | |||
| (.getPath analyzer-dir))) | |||
|
|
|||
| (defn ensure-pubspec-dependencies [] | |||
| (let [scan-pubspec (fn [filter-line-fn rf] | |||
| (->> (reduce (fn [[acc seen-cljd-tag] line] | |||
There was a problem hiding this comment.
I believe that we'll have to bite the bullet and use a proper yaml parser
cgrand
reviewed
Oct 23, 2023
| first | ||
| rf)) | ||
| ;; take all "old" deps from cljd libraries `pubspec.yaml` and remove them | ||
| _ (run! |
There was a problem hiding this comment.
one can pass all packages to a single pub remove
|
see #280 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
need @cgrand review + documentation on how to write a lib with dart/flutter deps