Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/json formatter #42

Merged
merged 17 commits into from
Aug 18, 2016
Merged

Feature/json formatter #42

merged 17 commits into from
Aug 18, 2016

Conversation

emoralesb05
Copy link
Contributor

@emoralesb05 emoralesb05 commented Aug 17, 2016

Description

First iteration of the Json Formatter Module.

What's included?

TdJsonFormatterComponent

Added component that facilitates formatting and navigation of JavaScript objects. Mimicking chrome console. This iteration contains:

  • Module docs and demo.
  • Added package.json
  • Added README.md
  • Tooltip children preview. ( max elements to render: 5)
  • Basic a11y (enter and tabbing).

Usage:

<td-json-formatter [data]="objData" [levelsOpen]="1"></td-json-formatter>

Properties:
image

Test Steps

Screenshots or link to CodePen/Plunker/JSfiddle

image

json-formatter-demo1

@emoralesb05 emoralesb05 added this to the Alpha 0.6 milestone Aug 17, 2016
@richavyas richavyas self-assigned this Aug 17, 2016
@richavyas
Copy link
Collaborator

@emoralesb05 - Is this how it is supposed to function?

covalent-ljson-formatter-error

@emoralesb05
Copy link
Contributor Author

Removed expand/collapse from demo since it was just for show and in some cases they werent synced with the actual levels opened in json-formatter. (not really needed)

@kyleledbetter
Copy link
Contributor

pushed a few cosmetic changes:
image

/**
* Gets parsed value depending on value type.
*/
getValue(value: any): string {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

scope of this method can be static

@kyleledbetter kyleledbetter merged commit 90fba53 into develop Aug 18, 2016
@emoralesb05 emoralesb05 deleted the feature/json-formatter branch August 18, 2016 20:53
kriswinbush pushed a commit to kriswinbush/covalent that referenced this pull request Feb 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants