fix: Prevent movement to origin after spawning #105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The MinionMoveComponent#goalPosition was initialized with the default vector (0,0,0), causing the _stray_ behavior to target this position as the first movement target. As this origin location is usually not reachable when an entity is spawned, we wasted a couple of seconds for computing a path until we finally aborted as "not reachable". With these changes, we can now distinguish between "no goal position" (null) and "explicit goal position" (any vector). We only attempt to find a path for non-null targets.
skaldarnar
added
Size: S
jdrueckert
previously approved these changes
Apr 10, 2022
jdrueckert
approved these changes
Apr 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The MinionMoveComponent#goalPosition was initialized with the default vector (0,0,0), causing the stray behavior to target this position as the first movement target.
As this origin location is usually not reachable when an entity is spawned, we wasted a couple of seconds for computing a path until we finally aborted as "not reachable".
With these changes, we can now distinguish between "no goal position" (null) and "explicit goal position" (any vector). We only attempt to find a path for non-null targets.