Added support for font, color, images #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skaldarnar
reviewed
Apr 16, 2017
| @In | ||
| private PrefabManager prefabManager; | ||
| private static PrefabManager prefabManager; |
There was a problem hiding this comment.
Using the static keywords means that all instances of the BookScreen share the same variable - is this intended for all the fields here?
There was a problem hiding this comment.
@skaldarnar Yes, since only a single BookScreen instance can stay active at any point of time, the usage of static everywhere in this class is intended. It is primarily done so to make some variables and methods (present in this class) accessible to the PageEditor class which is another such screen in this module.
|
Note: Updated PR to work with Prefab based recipes. This no longer needs the gson library to be whitelisted. |
|
Sorry for the delay. Exams happened recently and just got to this. |
This was referenced Dec 24, 2018
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The existing
UITextthat appeared over pages is now replaced withBrowserWidget.Using
BrowserWidgetas in Journal allows writing the page contents in a near HTML-like language.This allows for change of font, color and even addition of images.
Recipes can be added directly (as done in Journals). Will upload an example for the same soon.
Since the pages don't have UIText anymore, editing them opens a new window (PageEditor) where the contents appear unparsed, i.e. undecoded in the HTML-Like language currently.
The single edit button that existed has now been replaced with two, one for each page (left and right).
Saving the page inside the editing window (PageEditor) that pops up only saves the edit temporarily (for viewing purposes). To save it completely (i.e. write to BookComponent.pages) you need to click the save button on the BookScreen.
Recipes can be dynamically added using a "" tag, which consist of a prefab name, that has a BookRecipeComponent.
This would solve #3, #4 and #7
@Waterpicker @Cervator could you review?
Here's a video for the same:
https://www.youtube.com/watch?v=RDK5IN7v4y0