Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: remove Perlin #44

Merged
merged 1 commit into from
May 13, 2022
Merged

chore: remove Perlin #44

merged 1 commit into from
May 13, 2022

Conversation

jdrueckert
Copy link
Member

@jdrueckert jdrueckert added Size: S Small effort likely only affecting a single area and requiring little to no research Type: Chore Request for or implementation of maintenance changes Topic: WorldGen Requests, Issues and Changes related to facets, rasterizers, etc. labels May 10, 2022
@jdrueckert
Copy link
Member Author

Perlin removal

keturn
keturn approved these changes May 13, 2022
View reviewed changes
Copy link
Contributor

@keturn keturn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checks out fine, and the linked world generator PRs have been merged. Looks good to me!

though maybe leave a link in here to one of the many discussions about the rationale

@keturn keturn merged commit 33eea24 into develop May 13, 2022
@keturn keturn deleted the chore/remove-perlin branch May 13, 2022 19:12
@keturn keturn mentioned this pull request May 31, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@keturn keturn keturn approved these changes

Assignees
No one assigned
Labels
Size: S Small effort likely only affecting a single area and requiring little to no research Topic: WorldGen Requests, Issues and Changes related to facets, rasterizers, etc. Type: Chore Request for or implementation of maintenance changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jdrueckert @keturn