Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(getRandomLoot): use correct type for map query #13

Merged
merged 2 commits into from
Nov 8, 2021
Merged

fix(getRandomLoot): use correct type for map query #13

merged 2 commits into from
Nov 8, 2021

Conversation

keturn
Copy link
Contributor

@keturn keturn commented Nov 8, 2021

also addresses the checkstyle warning

@keturn keturn added Type: Bug Issues reporting and PRs fixing problems Good First Issue Good for learners that are new to Terasology Size: S Small effort likely only affecting a single area and requiring little to no research labels Nov 8, 2021
jdrueckert
jdrueckert approved these changes Nov 8, 2021
View reviewed changes
Copy link
Member

@jdrueckert jdrueckert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and tests out fine in iota with door drops 👍

@jdrueckert jdrueckert merged commit 5a1a208 into develop Nov 8, 2021
@jdrueckert jdrueckert deleted the fix/namesAreNotStrings branch November 8, 2021 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdrueckert jdrueckert jdrueckert approved these changes

Assignees
No one assigned
Labels
Good First Issue Good for learners that are new to Terasology Size: S Small effort likely only affecting a single area and requiring little to no research Type: Bug Issues reporting and PRs fixing problems
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@keturn @jdrueckert