test: add SettlementEntityManagerTest for placeParcel

[keturn]

Things to look for in review:

• null checks in SolidRasterizer: https://github.com/Terasology/DynamicCities/pull/107/files#diff-0359e59a9518a0236f47b3e3fb518e94ba5d0413810d01ca4cf5592c531381e2
  Should we try to work around nulls here, or should these be errors? Is there someplace higher-level that should enforce its requirements before it gets here?

Let me know if you want any of the checkstyle fixes or other refactorings split in to other PRs to reduce the noise in this one.

[keturn]

Test set-up has been slow going because everything really, really wants to be configured by prefabs, and I don't know how to add a prefab only for tests. See related discussion in #gestalt.

[keturn]

After some fiddling to make this not dependent on other work-in-progress, this is something like a test case that runs.

It doesn't pass, but it's starting to look like something that could pass.

The changes to the non-test classes are intended to be small refactorings to make the tests a little easier to write, plus some things CheckStyle complained about along the way.

[jdrueckert]

whoops, where did we forget this 🙈

[keturn]

TODO: javadoc

[jdrueckert]

Code-wise this looks fine to me. I didn't see anything that sparked specific concerns.
I'll give this a go in-game before approving.

[jdrueckert]

I would not think so. CoreWorlds as part of the core modules should always be enabled and has a TreeFacet, so I would guess if all else fails, that one should always be there, should it?

[keturn]

I don't know about that.

DynamicCities/src/main/java/org/terasology/dynamicCities/world/testbench/FlatFacetedWorld.java

Lines 36 to 46 in 4ec5c18

	protected WorldBuilder createWorld() {
	return new WorldBuilder(worldGeneratorPluginLibrary)
	.addProvider(new FlatSurfaceHeightProvider(SURFACE_HEIGHT))
	.addProvider(new SeaLevelProvider(SEA_LEVEL))
	.addProvider(new ConstantBiomeProvider(BIOME))
	.addProvider(new RoughnessProvider())
	.addProvider(new SiteFacetProvider())
	.addProvider(new SettlementFacetProvider())
	.addProvider(new ResourceProvider())
	.addEntities(new RegionEntityProvider())
	.addRasterizer(new SolidRasterizer())

is a world generator that does not provide a TreeFacet.

Can entity providers use the same @Requires annotations as FacetProviders can?

If so, then this EntityProvider could declare that it does depend on having a TreeFacet. (Once MovingBlocks/Terasology#4924 is fixed.)

[jdrueckert]

You're absolutely right, only because a TreeFacet exists in at least one of the modules, the world generator doesn't need to use it.

I don't know whether or not they can 🤷

[jdrueckert]

Found a city in-game, different kinds of buildings spawn fine, checks run through - good enough for me 👍