fix: avoid NPE in WalletClientSystem by using a binding #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`preBegin()`, despite its description, may be called only after the system already received events to its event handler. In that case, the `walletHud` was still null and causing an NPE in `onUpdateWallet`. By using a binding this NPE is avoided. The binding value can be updated from the event handler even before it was hooked up with the HUD element.
skaldarnar
added
Type: Bug
ahv15
approved these changes
Aug 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
preBegin(), despite its description, may be called only after the system already received events to its event handler. In that case, thewalletHudwas still null and causing an NPE inonUpdateWallet.By using a binding this NPE is avoided. The binding value can be updated from the event handler even before it was hooked up with the HUD element.