-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add food icon beside the Hunger Bar #30
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I feel like it helps associating the contents of this file with what you can see in-game if the elements are in the same "order", aka if the icon comes first and then the bar.
Further, I think we should make the horizontal placement of the bar relative to the icon. Thus, they'll always have the same offset even if you decide to move it further right or left by adjusting the icon's horizontal placement. I would recommend the following for the bar:
"position-left": {
"target": "LEFT",
"widget": "hungerIcon",
"offset": 47
},
Co-authored-by: jdrueckert <jd.rueckert@googlemail.com>
Co-authored-by: jdrueckert <jd.rueckert@googlemail.com>
As always, thank you for your assistance |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you test this in-game?
I don't expect it to work because for positioning the hungerIcon
widget you're referencing the hungerIcon
widget. You'll need to position the icon like you currently position the bar and positioning the bar referencing the icon.
@jdrueckert sorry for that. looks like i wasn't focusing right. i had tested the horizontal relative position in game (completely blanked that it would be a good idea to do the same for the vertical position as well) but when i began to edit the files for the commit, i reversed the solution. I have (hopefully now) corrected this, added also relative vertical position, and aligned everything again to the dot. |
add food icon indicator on the left of the hunger bar