-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
qa: checkstyle, pmd #52
qa: checkstyle, pmd #52
Conversation
BeforeItemRemovedFromInventory removeFrom = new BeforeItemRemovedFromInventory(instigator, InventoryUtils.getItemAt(from, | ||
slotFrom), slotFrom); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider breaking lines at more readable points, e.g.
BeforeItemRemovedFromInventory removeFrom = new BeforeItemRemovedFromInventory(instigator,
InventoryUtils.getItemAt(from, slotFrom), slotFrom);
While conventional commits are not mandatory within a PR (due to the fact that we're typically squash-merging), it does help people merging your PRs if you at least follow the convention in your PR titles |
rebased on top of your pull request so your commits with the respective commit messages are there. |
can you please include in the PR description, which checkstyle and pmd warnings you addressed? |
quality assurance of Inventory module, mainly: * line too long * logger not parameterized * intellij warnings about formatting, e.g. @ReceiveEvent(components = {InventoryComponent.class}) replaced with @ReceiveEvent(components = InventoryComponent.class) * unused private field
updated pull request text, as well as commit message of the respective commit accordingly. |
addressed pmd and checkstyle warnings: