Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: PHP syntax highlighting in completions #32

Merged
merged 2 commits into from
Jul 27, 2022
Merged

fix: PHP syntax highlighting in completions #32

merged 2 commits into from
Jul 27, 2022

Conversation

jfcherng
Copy link
Collaborator

image

Fixes #30

@jfcherng
fix: PHP syntax highlighting in completions
17135f1 
Signed-off-by: Jack Cherng <jfcherng@gmail.com>
@jfcherng jfcherng added the bug Something isn't working label Jul 27, 2022
@TerminalFi
Copy link
Owner

Can we strip <?php after we generate the HTML content?

@jfcherng
Copy link
Collaborator Author

jfcherng commented Jul 27, 2022 •
edited
Loading

Can we strip <?php after we generate the HTML content?

it's only for display. not sure what you mean.

@jfcherng
fix: 3 backticks in suggestion will break popup tempaltes
9342623 
We use many backticks to denote a fenced code block because if we are writing in Markdown,
Copilot may suggest 3 backticks for a fenced code block and that can break our templating.

```py
COMPLETION_TEMPLATE = reformat(
    """
    <div class="header">{header_items}</div>
    ``````{lang}
    {code}
    ``````
    """
)
```

Signed-off-by: Jack Cherng <jfcherng@gmail.com>
@TerminalFi
Copy link
Owner

Fixes #33

@jfcherng
Copy link
Collaborator Author

jfcherng commented Jul 27, 2022 •
edited
Loading

Fixes #33

Nope. #33 is another circumstance. But I am currently doing some experiments for it.

@jfcherng jfcherng merged commit 741c285 into master Jul 27, 2022
@jfcherng jfcherng deleted the fix/php-highlighting branch July 27, 2022 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TerminalFi TerminalFi TerminalFi left review comments

@timfjord timfjord timfjord left review comments

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

PHP completions need leading <?php to be highlighted properly
3 participants
@jfcherng @TerminalFi @timfjord