Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add compatibility for Chunk-Pregenerator #44

Merged

Conversation

jchung01
Copy link

@jchung01 jchung01 commented Apr 1, 2024

Seems like a relatively simple fix, should mean the Chunk-Pregenerator mod is compatible now. This is the only mod that I'm aware of that triggers the associated if block, that is:

if getBiome is called before the biome array is initialised the provider is queried to find the expected biome.

(taken from DimensionalDevelopment#42 (comment))
Tested seed -107391545297039861 on SP and the pregenerated chunks from Chunk-Pregenerator seem to have the correct biome now. Fixes #14, #40, DimensionalDevelopment#42.

- Should mean the Chunk-Pregenerator mod is compatible now
@ACGaming ACGaming merged commit 51b5641 into TerraFirmaCraft-The-Final-Frontier:master Apr 2, 2024
1 check passed
@BinBashBanana
Copy link

Thank you!!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incompatibility with Chunk Pregenerator
3 participants