Fix Crash on 24w18a when clicks the ModMenuOptions of this mod #729 #730
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for the contribution! This pull request was superseded by #734, which ports Mod Menu to a newer Minecraft version, so I will close this pull request. Version 11.0.0 beta 1 supports Minecraft 1.21 pre-release 2. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#729
The class GameOptionsScreen in 24w18a changed to an abstract class. So the edit of ModMenuModMenuCompat is needed.
1.20.6
24w18a
So the edit of this is needed. Otherwise, the remap and compile won't success.