Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate legacy Andisol ids #227

Open
FewerFlaws opened this issue Dec 28, 2020 · 7 comments
Open

Migrate legacy Andisol ids #227

FewerFlaws opened this issue Dec 28, 2020 · 7 comments
Labels
enhancement New feature or request

Comments

@FewerFlaws
Copy link

Andisol dirt, grass blocks, and podzol use "basalt_dirt" "basalt_grass_block" and "basalt_podzol" within the namespace. This is inconsistent because the grass path and farmland blocks use "andisol_grass_path" and "andisol_farmland."

I imagine you already know about this and decided not to correct it. I'm just pointing it out in case it's an oversight. I noticed it while working on compatibility between Presence Footsteps and Terrestria =]

@Prospector
Copy link
Member

Prospector commented Dec 29, 2020

Yeah, this cannot be reasonably changed without breaking worlds. Perhaps we can fix it in the transition to 1.17 by using a datafixer, but unfortunately I don't believe we can get datafixers to run easily between mod version changes.

Luckily, ultimately it doesn't really matter what the ids are.

@FewerFlaws
Copy link
Author

New development on this. REI displays "andisol_grass_path" in the interface, but F3 debug view reveals that a placed block uses "basalt_grass_path"
2020-12-28_22 56 55
2020-12-28_22 57 03

@Prospector
Copy link
Member

Yeah, the item was added later after the rename.

@FewerFlaws
Copy link
Author

Surely the tooltip issue can be fixed, right? The name shown in the extended F3+H tooltip should be the actual namespace name so that mod authors can see the block and reference it properly. Fixing that shouldn't break anything.

@FewerFlaws
Copy link
Author

Oh, I didn't describe the issue with the grass path properly. Check out that first screenshot to see the issue. The Andisol grass path's extended tooltip is displaying the wrong namespace block ID.

@Prospector
Copy link
Member

No it's not. Item IDs are different from block IDs.

@Prospector Prospector changed the title Andisol dirt, grass blocks, and podzol use "basalt" in namespace Migrate legacy Andisol ids Dec 30, 2020
@FewerFlaws
Copy link
Author

FewerFlaws commented Dec 30, 2020 via email

@coderbot16 coderbot16 added the enhancement New feature or request label Feb 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants