Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix GolanCI unchecked-error cries #19

Merged
merged 1 commit into from
Sep 8, 2018
Merged

Fix GolanCI unchecked-error cries #19

merged 1 commit into from
Sep 8, 2018

Conversation

Jaskaranbir
Copy link
Member

@Jaskaranbir Jaskaranbir commented Sep 8, 2018 •
edited
Loading

...keeping the nitpicky guy satisfied

golangcibot
golangcibot reviewed Sep 8, 2018
View reviewed changes
mongo/collection_test.go Outdated

hits := []int{}
for _, r := range findResults {
dbItem := r.(*item)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Error return value is not checked

mongo/collection_test.go Outdated

hits := []int{}
for _, r := range findResults {
dbItem := r.(*item)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Error return value is not checked

mongo/collection_test.go Outdated

hits := []int{}
for _, r := range findResults {
dbItem := r.(*item)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Error return value is not checked

@Jaskaranbir
Copy link
Member Author

bors r+

bors bot pushed a commit that referenced this pull request Sep 8, 2018
@ninja-bruh @Jaskaranbir
Merge #19
abebaa8 
19: Fix GolanCI unchecked-error cries r=Jaskaranbir a=Jaskaranbir

...keeping the nitpicky guy satisfied

Co-authored-by: Jaskaranbir <jaskaranbir.dhillon@gmail.com>
@Jaskaranbir Jaskaranbir mentioned this pull request Sep 8, 2018
Merged
@bors
Copy link

bors bot commented Sep 8, 2018

Build succeeded

@bors bors bot merged commit bcb38cd into master Sep 8, 2018
@bors bors bot deleted the golangci-err-chk-fix branch September 8, 2018 01:24
@Jaskaranbir Jaskaranbir added the bug Something isn't working label Sep 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@golangcibot golangcibot golangcibot left review comments

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Jaskaranbir @golangcibot