Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

More converters. #17

Merged
merged 14 commits into from
Dec 2, 2020
Merged

More converters. #17

merged 14 commits into from
Dec 2, 2020

Conversation

na9da
Copy link
Contributor

@na9da na9da commented Oct 21, 2020

Merge after #10

Adds converters for the following catalog items:

  • EsriMapServerCatalogGroup (esri-mapServer-group)
  • MapboxVectorTileCatalogItem (mvt)
  • CartoMapCatalogItem (carto)

Converts the trait forceProxy

Base automatically changed from add-more to master October 28, 2020 04:51
nf-s
nf-s requested changes Oct 28, 2020
View reviewed changes
Copy link
Contributor

@nf-s nf-s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good Nanda!
Can you please write a quick test for the three new types?

@nf-s nf-s assigned na9da and unassigned nf-s Nov 2, 2020
@nf-s nf-s mentioned this pull request Nov 9, 2020
Closed
@na9da
Copy link
Contributor Author

na9da commented Nov 24, 2020

@nf-s I have added the tests. Let me know if it is good to merge.
Thanks!

@nf-s nf-s merged commit 7307583 into master Dec 2, 2020
@nf-s nf-s deleted the add-even-more branch December 2, 2020 00:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nf-s nf-s nf-s requested changes

Assignees

@na9da na9da

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@na9da @nf-s