Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TerriaReference doesn't use description (and some other CatalogMemberReferenceTraits) #6871

Open
nf-s opened this issue Sep 5, 2023 · 3 comments
Labels

Comments

@nf-s
Copy link
Contributor

nf-s commented Sep 5, 2023

For the following example, the description is not used.

{
  "catalog": [
    {
      "id": "cEynH3ca",
      "name": "Agriculture",
      "path": [
        "cEynH3ca"
      ],
      "type": "terria-reference",
      "isGroup": true,
      "url": "https://terria-catalogs-public.storage.googleapis.com/nationalmap/catalog/agriculture/prod.json",
      "shareKeys": [
        "Root Group/National Datasets/Agriculture"
      ],
      "description": "something"
    }
  ]
}

We should support all CatalogMemberReferenceTraits - description, dataCustodian and isOpenInWorkbench.

Also, do a quick survey of all other Traits inherited by TerriaReference

@nf-s nf-s added the T-Bug label Sep 5, 2023
@nf-s
Copy link
Contributor Author

nf-s commented Sep 7, 2023

It might be worth considering adding GroupTraits too (eg excludeMembers)

@nf-s nf-s mentioned this issue Sep 7, 2023
4 tasks
@nf-s
Copy link
Contributor Author

nf-s commented Sep 7, 2023

@nf-s
Copy link
Contributor Author

nf-s commented Sep 7, 2023

Alternatively - we could just add itemProperties, and then that gets applied on top of resolved reference ItemPropertiesTraits are already in ReferenceTraits - this is not how itemProperties works

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant