Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zero a lot of uninitialized member vars #29

Merged
merged 2 commits into from
Jan 11, 2020
Merged

zero a lot of uninitialized member vars #29

merged 2 commits into from
Jan 11, 2020

Conversation

0x08088405
Copy link
Contributor

@0x08088405 0x08088405 commented Jan 11, 2020

Legal Stuff:

By submitting this pull request, I confirm that...

  • My changes may be used in a future commercial release of VVVVVV (for
    example, a 2.3 update on Steam for Windows/macOS/Linux)
  • I will be credited in a CONTRIBUTORS file for all of said releases, but
    will NOT be compensated for these changes

Changes:

I'm not sure why you need debug + RTC but a good chance is that it's related to uninitialized values which are zeroed in debug but not release (had this exact mystery headache a while ago). This just sets a bunch of otherwise uninitialized member vars to 0, also getting rid of one compiler warning per variable initialized. Neat.

Also fixes a spelling error (forground) in the graphics class's buffers.

also fix a spelling error of 'forground' in the graphics class buffer
@flibitijibibo
Copy link
Collaborator

Odd, for some reason none of these ever showed up in a Valgrind test (and still don't, to my knowledge). But yes, I will very happily take initialized memory fixes as they're found. Go ahead and add your name to desktop_version/CONTRIBUTORS.txt and I'll merge this in.

@0x08088405
Copy link
Contributor Author

0x08088405 commented Jan 11, 2020

Sure, hope that's good (just put a domain there that points to my GitHub since I intend on changing my username).
There's probably more uninitialized memory errors, there were some with the labclass type classes but they have an associated function for constructing (instead of a constructor) which is why it raised warnings so those are probably fine. I'll look for more weird ones later.

@flibitijibibo
Copy link
Collaborator

Thanks! No rush on this, but I'm definitely glad someone is interested in fixing the bizarre VS issues...

@flibitijibibo flibitijibibo merged commit 669072f into TerryCavanagh:master Jan 11, 2020
@flibitijibibo
Copy link
Collaborator

Thought I had this on file from a previous patch, but it turns out I don't... can you fill this out for me real quick?

## Legal Stuff:

By submitting this pull request, I confirm that...

- [ ] My changes may be used in a future commercial release of VVVVVV (for
  example, a 2.3 update on Steam for Windows/macOS/Linux)
- [ ] I will be credited in a `CONTRIBUTORS` file for all of said releases, but
  will NOT be compensated for these changes

@0x08088405
Copy link
Contributor Author

I wish GitHub would notify me, good thing I checked my PR for no particular reason.

Legal Stuff:

By submitting this pull request, I confirm that...

  • My changes may be used in a future commercial release of VVVVVV (for
    example, a 2.3 update on Steam for Windows/macOS/Linux)
  • I will be credited in a CONTRIBUTORS file for all of said releases, but
    will NOT be compensated for these changes

@flibitijibibo
Copy link
Collaborator

Awesome, thanks! (Also GitHub pls)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants