Test visitor decorators #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Aboisier
commented
Dec 7, 2018
| this.baseVisitTestSuite = baseVisitor.visitTestSuite.bind(baseVisitor); | ||
|
|
||
| this.baseVisitor.visitTest = this.visitTest.bind(this); | ||
| this.baseVisitor.visitTestSuite = this.visitTestSuite.bind(this); |
There was a problem hiding this comment.
This hack is very ugly. This is currently necessary because of the recursive nature of the visitor. When the bottommost visitor in the decorator hierarchy does its recursive call and passes this to the accept method, we lose the decorators.
I believe to move the iterating-over-children logic from the visitor to the composite might - perhaps - fix the problem.
There was a problem hiding this comment.
Okay so moving back the iteration inside the tree creates more problems (aka handling before/after methods execution, filtering the nodes, etc.). The hack doesn't seem that ugly after all. Will continue thinking about this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current test runner is not extensible. For example, the test reporting is embedded in the test runner class. Implementing the Visual Studio Code adapter involved a full re-implementation of the test runner.
I believe using a decorator pattern would allow extending the test runner (and eventually other test visitors) more easily.
Solves #3