Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test fake attributes #1496

Merged
merged 6 commits into from
Sep 18, 2021
Merged

test fake attributes #1496

merged 6 commits into from
Sep 18, 2021

Conversation

willmcgugan
Copy link
Collaborator

Fixes #1492

Type of changes

  • Bug fix
  • New feature
  • Documentation / docstrings
  • Tests
  • Other

Checklist

  • I've run the latest black with default args on new code.
  • I've updated CHANGELOG.md and CONTRIBUTORS.md where appropriate.
  • I've added tests for new code.
  • I accept that @willmcgugan may be pedantic in the code review.

Description

Please describe your changes here. If this fixes a bug, please link to the issue, if possible.

@codecov
Copy link

codecov bot commented Sep 18, 2021

Codecov Report

Merging #1496 (f613b3e) into master (b267be8) will decrease coverage by 0.05%.
The diff coverage is 73.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1496      +/-   ##
==========================================
- Coverage   99.79%   99.73%   -0.06%     
==========================================
  Files          71       71              
  Lines        6753     6765      +12     
==========================================
+ Hits         6739     6747       +8     
- Misses         14       18       +4     
Flag Coverage Δ
unittests 99.73% <73.33%> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
rich/pretty.py 98.74% <73.33%> (-1.26%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ce51285...f613b3e. Read the comment docs.

@willmcgugan willmcgugan merged commit 23aa717 into master Sep 18, 2021
@willmcgugan willmcgugan deleted the pretty-fix branch September 18, 2021 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] TypeError not callable : rich.print_exception
1 participant