Add Syntax.guess_lexer, add support for more lexers (e.g. Django templates etc.)
#1869
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1869 +/- ##
==========================================
- Coverage 99.82% 99.58% -0.24%
==========================================
Files 71 71
Lines 6943 7028 +85
==========================================
+ Hits 6931 6999 +68
- Misses 12 29 +17
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
This was referenced Jan 28, 2022
netbsd-srcmastr
pushed a commit
to NetBSD/pkgsrc
that referenced
this pull request
Jan 31, 2022
11.1.0 - 2022-01-28 Added Add Syntax.guess_lexer, add support for more lexers (e.g. Django templates etc.) Textualize/rich#1869 Add lexer parameter to Syntax.from_path to allow for overrides Textualize/rich#1873 Fixed Workaround for edge case of object from Faiss with no __class__ Textualize/rich#1838 Ensure Syntax always justifies left Textualize/rich#1872 Handle classes in inspect when methods=True Textualize/rich#1874
1 task
This was referenced Mar 7, 2022
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of changes
Checklist
Description
The code which determines which lexer to use was always using filename. If you gave it a file with
.htmlextension, it'd use the HTML lexer. This means that if you used e.g. a Django template with a file extension of.html, it would just use the HTML lexer, and not the Django one.This change ensures we take advantage of the analysis Pygments can perform to select the most appropriate lexer in cases like this.