-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add missing end
keyword argument to Text.from_markup
#2095
Merged
willmcgugan
merged 3 commits into
Textualize:master
from
wasi-master:fix-text-from-markup-end-param
Mar 22, 2022
Merged
Add missing end
keyword argument to Text.from_markup
#2095
willmcgugan
merged 3 commits into
Textualize:master
from
wasi-master:fix-text-from-markup-end-param
Mar 22, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Would you mind adding a test for this? |
Yeah I thought about that, Let's see... |
@willmcgugan So will this do? def test_end():
console = Console(width=20, file=StringIO())
test = Group(Text.from_markup("foo", end=" "), Text.from_markup("bar"))
console.print(test)
assert console.file.getvalue() == "foo bar\n" If you want I'll commit these |
Perfect |
@willmcgugan Done Ran the tests locally, passed :) |
willmcgugan
approved these changes
Mar 22, 2022
GitHub actions failed. Time to run black again |
Sorry for the inconvenience, forgot to run black on the new tests |
Great, thanks! |
This was referenced Apr 3, 2022
1 task
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of changes
Checklist
Description
Fixes #2054