Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Python 3.11.0-beta4 to CI #2394

Merged
merged 8 commits into from
Jul 26, 2022
Merged

Add Python 3.11.0-beta4 to CI #2394

merged 8 commits into from
Jul 26, 2022

Conversation

darrenburns
Copy link
Member

@darrenburns darrenburns commented Jul 14, 2022

  • Tests Rich against Python 3.11.0-beta4
  • There are issues with pytest-cov on 3.11 only. I'm going to minimally reproduce them and, if I can, report it to the pytest team. For now, coverage doesn't run on 3.11, but will continue to run on other versions.
  • There were 5 test failures that have been resolved.

@codecov-commenter
Copy link

codecov-commenter commented Jul 14, 2022

Codecov Report

Merging #2394 (a44aa44) into master (19e518f) will decrease coverage by 0.03%.
The diff coverage is 98.34%.

@@            Coverage Diff             @@
##           master    #2394      +/-   ##
==========================================
- Coverage   98.71%   98.67%   -0.04%     
==========================================
  Files          73       72       -1     
  Lines        7771     7767       -4     
==========================================
- Hits         7671     7664       -7     
- Misses        100      103       +3     
Flag Coverage Δ
unittests 98.67% <98.34%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
rich/default_styles.py 100.00% <ø> (ø)
rich/progress.py 92.76% <ø> (ø)
rich/segment.py 98.72% <93.10%> (+<0.01%) ⬆️
rich/_inspect.py 100.00% <100.00%> (ø)
rich/box.py 100.00% <100.00%> (ø)
rich/cells.py 96.05% <100.00%> (-3.95%) ⬇️
rich/color.py 100.00% <100.00%> (ø)
rich/console.py 98.30% <100.00%> (+0.01%) ⬆️
rich/highlighter.py 100.00% <100.00%> (ø)
rich/pretty.py 99.22% <100.00%> (+<0.01%) ⬆️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cde23ed...a44aa44. Read the comment docs.

Comment on lines +43 to +47
- name: Test with pytest (no coverage)
if: matrix.python-version == '3.11.0-beta.4'
run: |
source $VENV
pytest tests -v
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using --cov causes a silent failure on 3.11, so we run without coverage on that version for now.

@darrenburns darrenburns marked this pull request as ready for review July 15, 2022 13:03
@darrenburns darrenburns changed the title WIP Python 3.11 Testing Add Python 3.11 to CI Jul 15, 2022
@darrenburns darrenburns changed the title Add Python 3.11 to CI Add Python 3.11.0-beta4 to CI Jul 15, 2022
@darrenburns darrenburns linked an issue Jul 15, 2022 that may be closed by this pull request
@willmcgugan willmcgugan merged commit fc586b9 into master Jul 26, 2022
@willmcgugan willmcgugan deleted the python3.11b branch July 26, 2022 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Check latest Python beta against Rich
3 participants