Skip to content
This repository has been archived by the owner on Feb 22, 2021. It is now read-only.

- command rework #37

Draft
wants to merge 22 commits into
base: dev
Choose a base branch
from
Draft

- command rework #37

wants to merge 22 commits into from

Conversation

domlen2003
Copy link
Collaborator

No description provided.

Copy link
Owner

@Th3Ph4nt0m Th3Ph4nt0m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also note the sider check

@Th3Ph4nt0m
Copy link
Owner

That did not really make sider happy. We have 1595 issues now. Please revert the changes to the imports. I think that should solve at least the half of all these.

@domlen2003
Copy link
Collaborator Author

conclusion: sider is dumb af and should be reconfigured or disabled

@Th3Ph4nt0m
Copy link
Owner

No I don't think so. We should work on the configuration you're right there, but most of the issues found are just because our code is not spotless.

* Update sider.yml

* Update sider.yml

* Update sider.yml

* Update sider.yml
@domlen2003
Copy link
Collaborator Author

No I don't think so. We should work on the configuration you're right there, but most of the issues found are just because our code is not spotless.

well but intellij code cleanup seems to make sider angry

@domlen2003
Copy link
Collaborator Author

so what do we do?

@Th3Ph4nt0m
Copy link
Owner

We definitely should not make updates to sider's configuration in the same PR as the command rework! On the one hand, this is against the git-workflow, on the other hand, this PR will not be affected because sider takes the configuration from the target branch I think.

We should go through all the issue and solve them manually to have a good code.

@Th3Ph4nt0m Th3Ph4nt0m marked this pull request as draft January 11, 2021 13:49
@domlen2003
Copy link
Collaborator Author

ooops didnt see where i commited to

@domlen2003
Copy link
Collaborator Author

okay all sider changes are now reverted

@domlen2003
Copy link
Collaborator Author

also intellij cleanup is reverted but only brought more errors into sider check

wtf?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants