-
Notifications
You must be signed in to change notification settings - Fork 0
- command rework #37
base: dev
Are you sure you want to change the base?
- command rework #37
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also note the sider check
src/main/java/de/th3ph4nt0m/tdbot/commands/Administration/CMD_clear.java
Outdated
Show resolved
Hide resolved
src/main/java/de/th3ph4nt0m/tdbot/commands/Info/Bot/CMD_repo.java
Outdated
Show resolved
Hide resolved
src/main/java/de/th3ph4nt0m/tdbot/commands/Info/Bot/CMD_version.java
Outdated
Show resolved
Hide resolved
src/main/java/de/th3ph4nt0m/tdbot/commands/Info/CMD_serverinfo.java
Outdated
Show resolved
Hide resolved
src/main/java/de/th3ph4nt0m/tdbot/commands/Info/CMD_userinfo.java
Outdated
Show resolved
Hide resolved
src/main/java/de/th3ph4nt0m/tdbot/commands/Utils/CMD_flipcoin.java
Outdated
Show resolved
Hide resolved
That did not really make sider happy. We have 1595 issues now. Please revert the changes to the imports. I think that should solve at least the half of all these. |
conclusion: sider is dumb af and should be reconfigured or disabled |
No I don't think so. We should work on the configuration you're right there, but most of the issues found are just because our code is not spotless. |
* Update sider.yml * Update sider.yml * Update sider.yml * Update sider.yml
well but intellij code cleanup seems to make sider angry |
so what do we do? |
We definitely should not make updates to sider's configuration in the same PR as the command rework! On the one hand, this is against the git-workflow, on the other hand, this PR will not be affected because sider takes the configuration from the target branch I think. We should go through all the issue and solve them manually to have a good code. |
ooops didnt see where i commited to |
okay all sider changes are now reverted |
also intellij cleanup is reverted but only brought more errors into sider check wtf? |
No description provided.