Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improved keyvaultsigner #8

Merged
merged 1 commit into from
Sep 24, 2021
Merged

Improved keyvaultsigner #8

merged 1 commit into from
Sep 24, 2021

Conversation

ItalyPaleAle
Copy link
Contributor

  1. Added a timeout to all network requests - this is a best practice in Go, to avoid requests hanging forever (and so goroutines hanging forever)
  2. Fixed unhandled error in Sign
  3. Avoiding serializing and de-serializing public key to ASN.1

@ItalyPaleAle
Improved keyvaultsigner:
28562f9 
1. Added a timeout to all network requests
2. Fixed unhandled error
3. Avoiding serializing and de-serializing public key to ASN.1
@jgrangethales
Copy link
Contributor

thanks - will take a look

@jgrangethales jgrangethales self-assigned this Jul 21, 2021
jnsgruk
jnsgruk approved these changes Jul 21, 2021
View reviewed changes
Copy link
Contributor

@jnsgruk jnsgruk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good thanks! Feeling slightly embarrassed about the serialisation/deserialisation on reflection!

@ItalyPaleAle
Copy link
Contributor Author

ItalyPaleAle commented Sep 23, 2021 •
edited

Hey there, is there any update on when this may be merged?

@jgrangethales jgrangethales merged commit 6987461 into ThalesGroup:master Sep 24, 2021
@jgrangethales
Copy link
Contributor

Hey there, is there any update on when this may be merged?

apologies, thought i'd hit the button - done now

@ItalyPaleAle ItalyPaleAle mentioned this pull request Oct 13, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jnsgruk jnsgruk jnsgruk approved these changes

Assignees

@jgrangethales jgrangethales

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ItalyPaleAle @jgrangethales @jnsgruk