Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implemented JsonCPP Traits #317

Merged
merged 17 commits into from
Dec 16, 2023
Merged

Implemented JsonCPP Traits #317

merged 17 commits into from
Dec 16, 2023

Conversation

cjserio
Copy link
Contributor

@cjserio cjserio commented Dec 9, 2023

My project already makes heavy use of json-cpp so I put together this implementation of json-cpp traits for the jwt-cpp library since it seems like others have been asking for it as well.

@cjserio cjserio mentioned this pull request Dec 9, 2023
@prince-chrismc prince-chrismc linked an issue Dec 9, 2023 that may be closed by this pull request
@prince-chrismc
Copy link
Collaborator

Thank you so much for this great addition! This bit requires a bunch of CI to ensure consistency so I took the liberty of adding (most of it 🤞) there are a hand full of linter checks that are failing and I suspect there will be some compilation failures... especially in the test which I am not familiar with the API of this library.

Any help fixing it up will be appreciated!

I took some liberties with naming just to make it author-library without making it too long, open to suggestions but I know that name will eventually have other very similar projects :)

@prince-chrismc prince-chrismc added this to the 0.8.0 milestone Dec 9, 2023
@prince-chrismc
Copy link
Collaborator

@cjserio
Copy link
Contributor Author

cjserio commented Dec 9, 2023

You're welcome! It's a really popular library so I know it'll be helpful to people. I can take a look at the API issues this week if you'd like.

@prince-chrismc
Copy link
Collaborator

I think a future task will be to more the "linters" from nodejs to CMake so thier are more friendly to run locally because it's kinda a pain

@prince-chrismc prince-chrismc merged commit 65cda08 into Thalhammer:master Dec 16, 2023
56 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for jsoncpp
2 participants