Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Health calculation rework #1147

Closed
GizzleBizzle opened this issue May 14, 2023 · 3 comments · Fixed by #1281
Closed

Health calculation rework #1147

GizzleBizzle opened this issue May 14, 2023 · 3 comments · Fixed by #1281
Labels
bug Something isn't working core Issues related to the core programming database Issues related to the database

Comments

@GizzleBizzle
Copy link
Collaborator

Describe the bug
Currently all classes get +10 HP per stamina. That wasn't always the case as I'm about to prove.

Steps to reproduce

  1. Put on any stamina gear/buff on the character

Expected behavior
One point of stamina should result in:
20 additional HP for warriors
18 for paladins
16 for rogues, warlocks and shamans
14 for mages and priests

Because 0.6 changed this method,of calculating hp from stamina - Druids and Hunters couldn't be researched, as they became playable in 0.6 and 0.9 respectively. It is up to @GrenderG to decide how many hp they should get. Personally I believe they should be given 16 points per stam, since 14hp level seems to be reserved only for pure caster classes.

Proof
Some items have both stamina and flat HP stats
Forum talk about changing the formula yet again in 0.10 - Orlaba's post
Forum conversation mentioning health calculation standarization around 0.11 - GaboTheGreat's post
Chat conversation about hp values from stamina

And finally...
My GoogleDoc, where I've done the calculations - It will serve as a tool for the next project - tracking attribute changes throughout alpha lvling process. Don't worry if it looks unpolished. It will change in time.

@GizzleBizzle GizzleBizzle added bug Something isn't working database Issues related to the database core Issues related to the core programming labels May 14, 2023
@GrenderG
Copy link
Member

image
Interesting find. Where does the info regarding 14 for mages/priests come from?

@GrenderG
Copy link
Member

image
Some more chatting mentioning different hp/stamina per class.

@GizzleBizzle
Copy link
Collaborator Author

The druid's screenshot is from a revamped health calculation introduced in 0.6. The one I researched was from 0.5.5 and quite possibly 0.5.4 aswell, since what few screenshots we have from that patch seem to match my calculations.

As for the hp per stamina:

The base hp pool is 40 hp and you get it for the first 20 points of stamina on the character. Only after getting subsequent stamina points the calculation starts working.

I found out about this from lvl 1 warrior character sheet screenshots.
Dwarf warrior starts with 23 stam and 100 hp (40 hp base + (3×20hp from stamina)).
Human warriors start with 22 stam and 80 hp (40 + (2×20)).
Night elves start with 21 stam and 60 hp... you get the picture.

This was later proven for other classes. Proof in the GoogleDoc. The base hp for all classes is 40hp.

So the rest of the work was to find out as many screenshots where attributes were present and do some maths.

For instance - A human mage starts with 68 hp. Substract the base 40 hp and divide by 2 points of stam... voila.

PriestPriest was harder. I only found a lvl 2 one. Did more research and discovered that the flat mana and hp values gained from lvlups of a class are the same for all races of this class (both gnomes, humans and every other race will get +8 hp and +12 mana when reaching lvl 2 as a mage).

I found This and simply subtracted hp and mana. The result was 68 hp with 22 stam. The calculation was the same as priest's.

geo-tp added a commit to geo-tp/alpha-core that referenced this issue Aug 20, 2023
GrenderG pushed a commit that referenced this issue Aug 20, 2023
* fix #1147

* typo

* add comment

* correct druid and warlock stat
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working core Issues related to the core programming database Issues related to the database
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants