Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update setting_the_parameters.qmd replacing principal model run #89

Merged
merged 2 commits into from
Aug 7, 2024

Conversation

Josh-Cook3
Copy link
Contributor

Replaced text referring to principal model run with principal projection. Have hopefully kept the link to the summary page.

@Josh-Cook3 Josh-Cook3 linked an issue Aug 7, 2024 that may be closed by this pull request
Copy link
Member

@yiwen-h yiwen-h left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just made a small suggestion to link to the principal projection definition in the glossary. but it's not essential, can publish as is

user_guide/setting_the_parameters.qmd Outdated Show resolved Hide resolved
Co-authored-by: YiWen Hon <yiwen.hon1@nhs.net>
@Josh-Cook3 Josh-Cook3 merged commit 4fb1784 into main Aug 7, 2024
@Josh-Cook3 Josh-Cook3 deleted the Josh-Cook3/issue88 branch August 7, 2024 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change reference to 'principal model run'
2 participants