Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fit armstrong_number.cpp to guidelines #2457

Merged
merged 12 commits into from
Jun 20, 2023
Merged

fix: fit armstrong_number.cpp to guidelines #2457

merged 12 commits into from
Jun 20, 2023

Conversation

realstealthninja
Copy link
Collaborator

Description of Change

fixing armstrong number to be up to par with repository standards.

changes include:

  • documentation
  • math formula

Checklist

  • Added description of change
  • Added file name matches File name guidelines
  • Added tests and example, test must pass
  • Added documentation so that the program is self-explanatory and educational - Doxygen guidelines
  • Relevant documentation/comments is changed or added
  • PR title follows semantic commit guidelines
  • Search previous suggestions before making a new one, as yours may be a duplicate.
  • I acknowledge that all my contributions will be made under the project's license.

Notes: part of #2456

@Panquesito7 Panquesito7 added the enhancement New feature or request label May 16, 2023
Panquesito7
Panquesito7 reviewed May 30, 2023
View reviewed changes
Copy link
Member

@Panquesito7 Panquesito7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost there! 😄

math/armstrong_number.cpp Outdated Show resolved Hide resolved
math/armstrong_number.cpp Outdated Show resolved Hide resolved
realstealthninja and others added 2 commits June 16, 2023 13:28
@realstealthninja @Panquesito7
Update math/armstrong_number.cpp
a3c139b 
Co-authored-by: David Leal <halfpacho@gmail.com>
@realstealthninja @Panquesito7
Update math/armstrong_number.cpp
e8ad9ff 
Co-authored-by: David Leal <halfpacho@gmail.com>
Panquesito7
Panquesito7 approved these changes Jun 16, 2023
View reviewed changes
Copy link
Member

@Panquesito7 Panquesito7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 🚀
Will be merging in a few days if there are no objections. Feel free to ping me in case I forget about this. 🙂

@Panquesito7 Panquesito7 changed the title fix: fit armstrong_number.cpp to guidelines fix: fit armstrong_number.cpp to guidelines Jun 20, 2023
@Panquesito7 Panquesito7 merged commit 2fd530c into TheAlgorithms:master Jun 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Panquesito7 Panquesito7 Panquesito7 approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@realstealthninja @Panquesito7